Messages in this thread | | | Date | Tue, 18 Jun 2019 08:09:48 -0600 | From | Rob Herring <> | Subject | Re: [PATCH next v2] of/fdt: Fix defined but not used compiler warning |
| |
On Sat, 15 Jun 2019 11:03:43 +0800, Kefeng Wang wrote: > When CONFIG_OF_EARLY_FLATTREE is disabled, there is a compiler > warning, > > drivers/of/fdt.c:129:19: warning: ‘of_fdt_match’ defined but not used [-Wunused-function] > static int __init of_fdt_match(const void *blob, unsigned long node, > > Since the only caller of of_fdt_match() is of_flat_dt_match(), > let's move the body of of_fdt_match() into of_flat_dt_match() > and eliminate of_fdt_match(). > > Meanwhile, move of_fdt_is_compatible() under CONFIG_OF_EARLY_FLATTREE, > as all callers are over there. > > Cc: Stephen Boyd <swboyd@chromium.org> > Cc: Rob Herring <robh@kernel.org> > Cc: Frank Rowand <frowand.list@gmail.com> > Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com> > --- > v2: > -Move the body of of_fdt_match() into of_flat_dt_match(), suggested by Frank. > > drivers/of/fdt.c | 99 ++++++++++++++++++++++-------------------------- > 1 file changed, 45 insertions(+), 54 deletions(-) >
Applied, thanks.
Rob
| |