Messages in this thread | | | Date | Tue, 18 Jun 2019 16:55:22 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH V3 4/5] cpufreq: Register notifiers with the PM QoS framework |
| |
On 18-06-19, 01:26, Rafael J. Wysocki wrote: > On Monday, June 10, 2019 12:51:35 PM CEST Viresh Kumar wrote: > > +static int cpufreq_notifier_min(struct notifier_block *nb, unsigned long freq, > > + void *data) > > +{ > > + struct cpufreq_policy *policy = container_of(nb, struct cpufreq_policy, nb_min); > > + > > + return cpufreq_update_freq(policy); > > +} > > + > > +static int cpufreq_notifier_max(struct notifier_block *nb, unsigned long freq, > > + void *data) > > +{ > > + struct cpufreq_policy *policy = container_of(nb, struct cpufreq_policy, nb_max); > > + > > + return cpufreq_update_freq(policy); > > +} > > This is a bit convoluted. > > Two different notifiers are registered basically for the same thing. > > Any chance to use just one?
The way QoS is designed, it handles one value only at a time and we need two, min/max. I thought a lot about it earlier and this is what I came up with :(
You have any suggestions here ?
-- viresh
| |