Messages in this thread | | | Date | Tue, 18 Jun 2019 11:55:21 +0200 | From | Alexandre Belloni <> | Subject | Re: [PATCH 0/7] clk: at91: sckc: improve error path |
| |
On 13/06/2019 15:37:06+0000, Claudiu.Beznea@microchip.com wrote: > From: Claudiu Beznea <claudiu.beznea@microchip.com> > > Hi, > > This series tries to improve error path for slow clock registrations > by adding functions to free resources and using them on failures. >
Does the platform even boot when the slow clock is not available?
The TCB clocksource would fail at:
tc.slow_clk = of_clk_get_by_name(node->parent, "slow_clk"); if (IS_ERR(tc.slow_clk)) return PTR_ERR(tc.slow_clk);
> It is created on top of patch series at [1]. > > Thank you, > Claudiu Beznea > > [1] https://lore.kernel.org/lkml/1558433454-27971-1-git-send-email-claudiu.beznea@microchip.com/ > > Claudiu Beznea (7): > clk: at91: sckc: add support to free slow oscillator > clk: at91: sckc: add support to free slow rc oscillator > clk: at91: sckc: add support to free slow clock osclillator > clk: at91: sckc: improve error path for sam9x5 sck register > clk: at91: sckc: remove unnecessary line > clk: at91: sckc: improve error path for sama5d4 sck registration > clk: at91: sckc: use dedicated functions to unregister clock > > drivers/clk/at91/sckc.c | 122 ++++++++++++++++++++++++++++++++++-------------- > 1 file changed, 86 insertions(+), 36 deletions(-) > > -- > 2.7.4 >
-- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |