Messages in this thread | | | Subject | Re: [PATCH 3/8] sched,fair: redefine runnable_load_avg as the sum of task_h_load | From | Dietmar Eggemann <> | Date | Tue, 18 Jun 2019 11:08:09 +0200 |
| |
Hi Rik,
On 6/12/19 9:32 PM, Rik van Riel wrote:
[...]
> @@ -379,17 +368,11 @@ int update_irq_load_avg(struct rq *rq, u64 running) > * We can safely remove running from rq->clock because > * rq->clock += delta with delta >= running > */ > - ret = ___update_load_sum(rq->clock - running, &rq->avg_irq, > - 0, > - 0, > - 0); > - ret += ___update_load_sum(rq->clock, &rq->avg_irq, > - 1, > - 1, > - 1); > + ret = ___update_load_sum(rq->clock - running, &rq->avg_irq, 0); > + ret += ___update_load_sum(rq->clock, &rq->avg_irq, 1);
The 'int running' argument in the two ___update_load_sum() calls is missing. Doesn't compile for me (arm64 defconfig w/ CONFIG_IRQ_TIME_ACCOUNTING=y).
[...]
| |