lkml.org 
[lkml]   [2019]   [Jun]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe
    On Tue, 18 Jun 2019 17:11:15 -0400
    Steven Rostedt <rostedt@goodmis.org> wrote:

    > On Tue, 18 Jun 2019 12:23:22 -0400
    > Steven Rostedt <rostedt@goodmis.org> wrote:
    >
    > > > Oops, good catch!
    > > > This part is related to caller (ftrace/perf) so should be more careful.
    > > > Usually, kprobe enablement should not fail. If one of them has
    > > > gone (like a probe on unloaded module), it can be fail but that
    > > > should be ignored. I would like to add some additional check so that
    > > > - If all kprobes are on the module which is unloaded, enablement
    > > > must be failed and return error.
    > > > - If any kprobe is enabled, and others are on non-exist modules,
    > > > it should succeeded and return OK.
    > > > - If any kprobe caused an error not because of unloaded module,
    > > > all other enablement should be canceled and return error.
    > > >
    > > > Is that OK for you?
    > > >
    > >
    > > Sounds good to me.
    >
    > BTW,
    >
    > I pulled in patches 1-9 and I'm starting to test them now.

    Thanks! Should I send 10-21 patches in v2?

    Thank you,




    --
    Masami Hiramatsu <mhiramat@kernel.org>

    \
     
     \ /
      Last update: 2019-06-19 04:29    [W:2.675 / U:0.368 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site