lkml.org 
[lkml]   [2019]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] net: lio_core: fix potential sign-extension overflow on large shift
    Date
    From: Colin Ian King <colin.king@canonical.com>

    Left shifting the signed int value 1 by 31 bits has undefined behaviour
    and the shift amount oq_no can be as much as 63. Fix this by widening
    the int 1 to 1ULL.

    Addresses-Coverity: ("Bad shift operation")
    Fixes: f21fb3ed364b ("Add support of Cavium Liquidio ethernet adapters")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    ---
    drivers/net/ethernet/cavium/liquidio/lio_core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/cavium/liquidio/lio_core.c b/drivers/net/ethernet/cavium/liquidio/lio_core.c
    index 1c50c10b5a16..e78bdcee200f 100644
    --- a/drivers/net/ethernet/cavium/liquidio/lio_core.c
    +++ b/drivers/net/ethernet/cavium/liquidio/lio_core.c
    @@ -964,7 +964,7 @@ static void liquidio_schedule_droq_pkt_handlers(struct octeon_device *oct)

    if (droq->ops.poll_mode) {
    droq->ops.napi_fn(droq);
    - oct_priv->napi_mask |= (1 << oq_no);
    + oct_priv->napi_mask |= (1ULL << oq_no);
    } else {
    tasklet_schedule(&oct_priv->droq_tasklet);
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-06-17 17:53    [W:5.438 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site