lkml.org 
[lkml]   [2019]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 1/2] mm: soft-offline: return -EBUSY if set_hwpoison_free_buddy_page() fails
    Date
    The pass/fail of soft offline should be judged by checking whether the
    raw error page was finally contained or not (i.e. the result of
    set_hwpoison_free_buddy_page()), but current code do not work like that.
    So this patch is suggesting to fix it.

    Without this fix, there are cases where madvise(MADV_SOFT_OFFLINE) may
    not offline the original page and will not return an error. It might
    lead us to misjudge the test result when set_hwpoison_free_buddy_page()
    actually fails.

    Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
    Fixes: 6bc9b56433b76 ("mm: fix race on soft-offlining")
    Cc: <stable@vger.kernel.org> # v4.19+
    ---
    ChangeLog v2->v3:
    - update patch description to clarify user visible change
    ---
    mm/memory-failure.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git v5.2-rc4/mm/memory-failure.c v5.2-rc4_patched/mm/memory-failure.c
    index 8da0334..8ee7b16 100644
    --- v5.2-rc4/mm/memory-failure.c
    +++ v5.2-rc4_patched/mm/memory-failure.c
    @@ -1730,6 +1730,8 @@ static int soft_offline_huge_page(struct page *page, int flags)
    if (!ret) {
    if (set_hwpoison_free_buddy_page(page))
    num_poisoned_pages_inc();
    + else
    + ret = -EBUSY;
    }
    }
    return ret;
    --
    2.7.0
    \
     
     \ /
      Last update: 2019-06-17 10:52    [W:3.919 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site