Messages in this thread Patch in this message | | | From | <> | Subject | [v2 6/9] hwmon: (nct7904) Fix wrong return code in function nct7904_write_fan. | Date | Mon, 17 Jun 2019 08:14:35 +0000 |
| |
From: "amy.shih" <amy.shih@advantech.com.tw>
In function nct7904_write_fan, the return code is either 0 or an error code. 0x1fff is not a valid return code. Thus, set return code to 0 when setting value is smaller or equal to 0.
Signed-off-by: amy.shih <amy.shih@advantech.com.tw> --- Changes in v2: - Fix wrong return code 0x1fff in function nct7904_write_fan.
drivers/hwmon/nct7904.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c index 95348eebe8e4..3fa3eb31d176 100644 --- a/drivers/hwmon/nct7904.c +++ b/drivers/hwmon/nct7904.c @@ -551,7 +551,7 @@ static int nct7904_write_fan(struct device *dev, u32 attr, int channel, switch (attr) { case hwmon_fan_min: if (val <= 0) - return 0x1fff; + return 0; val = clamp_val((1350000 + (val >> 1)) / val, 1, 0x1fff); tmp = (val >> 5) & 0xff; -- 2.17.1
| |