Messages in this thread | | | Date | Mon, 17 Jun 2019 22:17:08 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH][V2] net: lio_core: fix potential sign-extension overflow on large shift |
| |
On Mon, Jun 17, 2019 at 05:12:49PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > Left shifting the signed int value 1 by 31 bits has undefined behaviour > and the shift amount oq_no can be as much as 63. Fix this by using > BIT_ULL(oq_no) instead. > > Addresses-Coverity: ("Bad shift operation") > Fixes: f21fb3ed364b ("Add support of Cavium Liquidio ethernet adapters") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > ---
Looks good. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| |