Messages in this thread | | | From | Heiko Stübner <> | Subject | Re: [PATCH 1/2] drm/rockchip: Properly adjust to a true clock in adjusted_mode | Date | Sun, 16 Jun 2019 15:41:22 +0200 |
| |
Am Samstag, 15. Juni 2019, 00:47:29 CEST schrieb Douglas Anderson: > When fixing up the clock in vop_crtc_mode_fixup() we're not doing it > quite correctly. Specifically if we've got the true clock 266666667 Hz, > we'll perform this calculation: > 266666667 / 1000 => 266666 > > Later when we try to set the clock we'll do clk_set_rate(266666 * > 1000). The common clock framework won't actually pick the proper clock > in this case since it always wants clocks <= the specified one. > > Let's solve this by using DIV_ROUND_UP. > > Fixes: b59b8de31497 ("drm/rockchip: return a true clock rate to adjusted_mode") > Signed-off-by: Douglas Anderson <dianders@chromium.org> > Signed-off-by: Sean Paul <seanpaul@chromium.org> > Reviewed-by: Yakir Yang <ykk@rock-chips.com>
I gave both patches a testrun on rk3288, rk3328 and rk3399 and applied them to drm-misc-next thereafter
Thanks Heiko
| |