| Date | Sun, 16 Jun 2019 11:55:03 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [RFC PATCH v4 18/21] x86/apic: Add a parameter for the APIC delivery mode |
| |
On Thu, 23 May 2019, Ricardo Neri wrote: > > struct irq_cfg { > - unsigned int dest_apicid; > - unsigned int vector; > + unsigned int dest_apicid; > + unsigned int vector; > + enum ioapic_irq_destination_types delivery_mode;
And how is this related to IOAPIC? I know this enum exists already, but in connection with MSI this does not make any sense at all.
> + > + /* > + * Initialize the delivery mode of this irq to match the > + * default delivery mode of the APIC. This is useful for > + * children irq domains which want to take the delivery > + * mode from the individual irq configuration rather > + * than from the APIC. > + */ > + apicd->hw_irq_cfg.delivery_mode = apic->irq_delivery_mode;
And here it's initialized from apic->irq_delivery_mode, which is an u32. Intuitive and consistent - NOT!
Thanks,
tglx
|