Messages in this thread | | | Subject | Re: memory leak in tipc_buf_acquire | From | Ying Xue <> | Date | Sun, 16 Jun 2019 15:02:05 +0800 |
| |
On 6/10/19 2:44 AM, Xin Long wrote: > Looks we need to purge each member's deferredq list in tipc_group_delete(): > diff --git a/net/tipc/group.c b/net/tipc/group.c > index 992be61..23823eb 100644 > --- a/net/tipc/group.c > +++ b/net/tipc/group.c > @@ -218,6 +218,7 @@ void tipc_group_delete(struct net *net, struct > tipc_group *grp) > > rbtree_postorder_for_each_entry_safe(m, tmp, tree, tree_node) { > tipc_group_proto_xmit(grp, m, GRP_LEAVE_MSG, &xmitq); > + __skb_queue_purge(&m->deferredq); > list_del(&m->list); > kfree(m); > }
Good catch! I agree with you.
| |