Messages in this thread | | | Date | Fri, 14 Jun 2019 08:49:25 -0700 (PDT) | Subject | Re: [PATCH net-next v3 2/2] hinic: add support for rss parameters with ethtool | From | David Miller <> |
| |
From: Michal Kubecek <mkubecek@suse.cz> Date: Fri, 14 Jun 2019 09:32:09 +0200
> On Thu, Jun 13, 2019 at 01:58:02AM +0000, Xue Chaojing wrote: >> This patch adds support rss parameters with ethtool, >> user can change hash key, hash indirection table, hash >> function by ethtool -X, and show rss parameters by ethtool -x. >> >> Signed-off-by: Xue Chaojing <xuechaojing@huawei.com> >> --- > > If you are going to submit a new version, please split the patch into > one moving the existing ethtool code into a new file and one with the > new features so that it's clear what is new. > > I'm also not sure if an error lever message in kernel log is an > appropriate response to user trying to perform an unsupported operation, > in particular if it can be triggered by a regular user.
I think no log message should be reported.
| |