lkml.org 
[lkml]   [2019]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/10] blkcg: implement BPF_PROG_TYPE_IO_COST
Hello, Quentin.

On Fri, Jun 14, 2019 at 12:32:09PM +0100, Quentin Monnet wrote:
> Please make sure to update the documentation and bash
> completion when adding the new type to bpftool. You
> probably want something like the diff below.

Thank you so much. Will incorporate them. Just in case, while it's
noted in the head message, I lost the RFC marker while prepping this
patch. It isn't yet clear whether we'd really need custom cost
functions and this patch is included more as a proof of concept. If
it turns out that this is beneficial enough, the followings need to be
answered.

* Is block ioctl the right mechanism to attach these programs?

* Are there more parameters that need to be exposed to the programs?

* It'd be great to have efficient access to per-blockdev and
per-blockdev-cgroup-pair storages available to these programs so
that they can keep track of history. What'd be the best of way of
doing that considering the fact that these programs will be called
per each IO and the overhead can add up quickly?

Thanks.

--
tejun

\
 
 \ /
  Last update: 2019-06-14 16:53    [W:0.092 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site