Messages in this thread | | | Date | Fri, 14 Jun 2019 11:23:55 +0100 | From | Will Deacon <> | Subject | Re: [PATCH] arm64/sve: <uapi/asm/ptrace.h> should not depend on <uapi/linux/prctl.h> |
| |
On Thu, Jun 13, 2019 at 06:14:44PM +0100, Dave Martin wrote: > On Thu, Jun 13, 2019 at 06:38:01PM +0200, Anisse Astier wrote: > > */ > > -#define SVE_PT_VL_INHERIT (PR_SVE_VL_INHERIT >> 16) > > -#define SVE_PT_VL_ONEXEC (PR_SVE_SET_VL_ONEXEC >> 16) > > +#define SVE_PT_VL_INHERIT (1 << 1) /* PR_SVE_VL_INHERIT */ > > +#define SVE_PT_VL_ONEXEC (1 << 2) /* PR_SVE_SET_VL_ONEXEC */ > > Makes sense, but... > > Since sve_context.h was already introduced to solve a closely related > problem, I wonder whether we can provide shadow definitions there, > similarly to way the arm64/include/uapi/asm/ptrace.h definitions are > derived. Although it's a slight abuse of that header, I think that > would be my preferred approach.
Yes, that sounds better to me as well. Please send a v2!
Will
| |