lkml.org 
[lkml]   [2019]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 017/118] thermal: rcar_gen3_thermal: disable interrupt in .remove
    Date
    [ Upstream commit 63f55fcea50c25ae5ad45af92d08dae3b84534c2 ]

    Currently IRQ remains enabled after .remove, later if device is probed,
    IRQ is requested before .thermal_init, this may cause IRQ function be
    called before device is initialized.

    this patch disables interrupt in .remove, to ensure irq function
    only be called after device is fully initialized.

    Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
    Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
    Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/thermal/rcar_gen3_thermal.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
    index 7aed5337bdd3..704c8ad045bb 100644
    --- a/drivers/thermal/rcar_gen3_thermal.c
    +++ b/drivers/thermal/rcar_gen3_thermal.c
    @@ -328,6 +328,9 @@ MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids);
    static int rcar_gen3_thermal_remove(struct platform_device *pdev)
    {
    struct device *dev = &pdev->dev;
    + struct rcar_gen3_thermal_priv *priv = dev_get_drvdata(dev);
    +
    + rcar_thermal_irq_set(priv, false);

    pm_runtime_put(dev);
    pm_runtime_disable(dev);
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-06-13 18:21    [W:4.152 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site