lkml.org 
[lkml]   [2019]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.1 129/155] video: hgafb: fix potential NULL pointer dereference
    Date
    [ Upstream commit ec7f6aad57ad29e4e66cc2e18e1e1599ddb02542 ]

    When ioremap fails, hga_vram should not be dereferenced. The fix
    check the failure to avoid NULL pointer dereference.

    Signed-off-by: Kangjie Lu <kjlu@umn.edu>
    Cc: Aditya Pakki <pakki001@umn.edu>
    Cc: Ferenc Bakonyi <fero@drama.obuda.kando.hu>
    [b.zolnierkie: minor patch summary fixup]
    Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/video/fbdev/hgafb.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c
    index 463028543173..59e1cae57948 100644
    --- a/drivers/video/fbdev/hgafb.c
    +++ b/drivers/video/fbdev/hgafb.c
    @@ -285,6 +285,8 @@ static int hga_card_detect(void)
    hga_vram_len = 0x08000;

    hga_vram = ioremap(0xb0000, hga_vram_len);
    + if (!hga_vram)
    + goto error;

    if (request_region(0x3b0, 12, "hgafb"))
    release_io_ports = 1;
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-06-13 17:56    [W:4.056 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site