lkml.org 
[lkml]   [2019]   [Jun]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 10/34] media: i2c: ov2640: simplify getting the adapter of a client
    On Sat, Jun 08, 2019 at 12:55:49PM +0200, Wolfram Sang wrote:
    > We have a dedicated pointer for that, so use it. Much easier to read and
    > less computation involved.
    >
    > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

    Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

    > ---
    >
    > Please apply to your subsystem tree.
    >
    > drivers/media/i2c/ov2640.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/media/i2c/ov2640.c b/drivers/media/i2c/ov2640.c
    > index 83031cfc7914..30e7e6b2b293 100644
    > --- a/drivers/media/i2c/ov2640.c
    > +++ b/drivers/media/i2c/ov2640.c
    > @@ -1197,7 +1197,7 @@ static int ov2640_probe(struct i2c_client *client,
    > const struct i2c_device_id *did)
    > {
    > struct ov2640_priv *priv;
    > - struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent);
    > + struct i2c_adapter *adapter = client->adapter;
    > int ret;
    >
    > if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA)) {
    > --
    > 2.19.1
    >

    \
     
     \ /
      Last update: 2019-06-13 17:44    [W:4.470 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site