Messages in this thread | | | From | Po-Hsu Lin <> | Date | Thu, 13 Jun 2019 18:28:44 +0800 | Subject | Re: [PATCH] selftests/net: skip psock_tpacket test if KALLSYMS was not enabled |
| |
Hello,
This issue was spotted on Ubuntu linux-kvm kernel, on which the CONFIG_KALLSYMS was disabled intentionally. I think this extra check could be helpful when running the net test directly. $ make -C tools/testing/selftests TARGETS=net run_tests
Also, there is an identical check implemented in the ftrace kprobe_args_symbol test.
I can send V2 along with CONFIG_KALLSYMS appended to the "config" file if you agree with this.
Thanks
On Thu, Jun 13, 2019 at 12:27 AM David Miller <davem@davemloft.net> wrote: > > From: Po-Hsu Lin <po-hsu.lin@canonical.com> > Date: Wed, 12 Jun 2019 14:47:52 +0800 > > > The psock_tpacket test will need to access /proc/kallsyms, this would > > require the kernel config CONFIG_KALLSYMS to be enabled first. > > > > Check the file existence to determine if we can run this test. > > > > Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com> > > Please just add CONFIG_KALLSYMS to "config".
| |