Messages in this thread | | | From | Sinan Kaya <> | Subject | Re: [PATCH 6/6] dma: qcom: hidma: no need to check return value of debugfs_create functions | Date | Wed, 12 Jun 2019 12:17:31 -0400 |
| |
On 6/12/2019 11:39 AM, Greg Kroah-Hartman wrote: >> Interesting. Wouldn't debugfs_create_file() blow up if dir is NULL >> for some reason? > It will create a file in the root of debugfs. But how will that happen? > debugfs_create_dir() can not return NULL.
I see.
> >> + debugfs_create_file("stats", S_IRUGO, dir, chan, >> + &hidma_chan_fops); >> >> Note that code ignores the return value of hidma_debug_init(); >> It was just trying to do clean up on debugfs failure by calling >> >> debugfs_remove_recursive(dmadev->debugfs); > Is that a problem?
I just wanted to double check. You probably want to remove the return value on debugfs_create_file() to prevent others from doing the same thing.
Acked-by: Sinan Kaya <okaya@kernel.org>
| |