lkml.org 
[lkml]   [2019]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: mce: no need to check return value of debugfs_create functions
On Wed, Jun 12, 2019 at 05:18:56PM +0200, Borislav Petkov wrote:
> On Wed, Jun 12, 2019 at 05:15:31PM +0200, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
> >
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: <x86@kernel.org>
> > Cc: Tony Luck <tony.luck@intel.com>
> > Cc: Vishal Verma <vishal.l.verma@intel.com>
> > Cc: Pu Wen <puwen@hygon.cn>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > arch/x86/kernel/cpu/mce/core.c | 16 +++++---------
> > arch/x86/kernel/cpu/mce/inject.c | 34 +++++-------------------------
> > arch/x86/kernel/cpu/mce/severity.c | 14 +++---------
> > 3 files changed, 13 insertions(+), 51 deletions(-)
>
> I think I'm having a deja-vu:
>
> https://lkml.kernel.org/r/20190122215326.GM26587@zn.tnic

Ah, I thought I had sent this out before...

Anyway, I'll fix this up, but really, you will not have a debugfs file
fail creation unless the system is totally out of memory...

thanks,

greg k-h

\
 
 \ /
  Last update: 2019-06-12 17:43    [W:0.047 / U:6.488 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site