lkml.org 
[lkml]   [2019]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH][next] leds: lm36274: remove redundant initialization of variable ret
Date
From: Colin Ian King <colin.king@canonical.com>

The variable ret is being initialized with a value that is never
read, hence it is redundant and can be removed. Also move the
declaration of ret to the for loop scope.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/leds/leds-lm36274.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/leds-lm36274.c b/drivers/leds/leds-lm36274.c
index ed9dc857ec8f..b55bd238c074 100644
--- a/drivers/leds/leds-lm36274.c
+++ b/drivers/leds/leds-lm36274.c
@@ -74,7 +74,6 @@ static int lm36274_parse_dt(struct lm36274 *lm36274_data)
struct device *dev = &lm36274_data->pdev->dev;
const char *name;
int child_cnt;
- int ret = -EINVAL;

/* There should only be 1 node */
child_cnt = device_get_child_node_count(dev);
@@ -82,6 +81,8 @@ static int lm36274_parse_dt(struct lm36274 *lm36274_data)
return -EINVAL;

device_for_each_child_node(dev, child) {
+ int ret;
+
ret = fwnode_property_read_string(child, "label", &name);
if (ret)
snprintf(label, sizeof(label),
--
2.20.1
\
 
 \ /
  Last update: 2019-06-12 16:57    [W:0.030 / U:19.524 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site