lkml.org 
[lkml]   [2019]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] media: vsp1: drm: Remove vsp1_du_setup_lif()
Hi Kieran,

Thank you for the patch.

On Fri, May 17, 2019 at 11:31:43PM +0100, Kieran Bingham wrote:
> The vsp1_du_setup_lif() function is deprecated, and the users have been
> removed. Remove the implementation and the associated configuration
> structure.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> drivers/media/platform/vsp1/vsp1_drm.c | 47 --------------------------
> include/media/vsp1.h | 22 ------------
> 2 files changed, 69 deletions(-)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_drm.c b/drivers/media/platform/vsp1/vsp1_drm.c
> index ce5c0780680f..12f76344bdec 100644
> --- a/drivers/media/platform/vsp1/vsp1_drm.c
> +++ b/drivers/media/platform/vsp1/vsp1_drm.c
> @@ -817,53 +817,6 @@ int vsp1_du_atomic_disable(struct device *dev, unsigned int pipe_index)
> }
> EXPORT_SYMBOL_GPL(vsp1_du_atomic_disable);
>
> -/**
> - * vsp1_du_setup_lif - Setup the output part of the VSP pipeline
> - * @dev: the VSP device
> - * @pipe_index: the DRM pipeline index
> - * @cfg: the LIF configuration
> - *
> - * Configure the output part of VSP DRM pipeline for the given frame @cfg.width
> - * and @cfg.height. This sets up formats on the BRx source pad, the WPF sink and
> - * source pads, and the LIF sink pad.
> - *
> - * The @pipe_index argument selects which DRM pipeline to setup. The number of
> - * available pipelines depend on the VSP instance.
> - *
> - * As the media bus code on the blend unit source pad is conditioned by the
> - * configuration of its sink 0 pad, we also set up the formats on all blend unit
> - * sinks, even if the configuration will be overwritten later by
> - * vsp1_du_setup_rpf(). This ensures that the blend unit configuration is set to
> - * a well defined state.
> - *
> - * Return 0 on success or a negative error code on failure.
> - */
> -int vsp1_du_setup_lif(struct device *dev, unsigned int pipe_index,
> - const struct vsp1_du_lif_config *cfg)
> -{
> - int ret;
> -
> - struct vsp1_du_modeset_config modes = {
> - .width = cfg->width,
> - .height = cfg->height,
> - .interlaced = cfg->interlaced,
> - };
> - struct vsp1_du_enable_config enable = {
> - .callback = cfg->callback,
> - .callback_data = cfg->callback_data,
> - };
> -
> - if (!cfg)
> - return vsp1_du_atomic_disable(dev, pipe_index);
> -
> - ret = vsp1_du_atomic_modeset(dev, pipe_index, &modes);
> - if (ret)
> - return ret;
> -
> - return vsp1_du_atomic_enable(dev, pipe_index, &enable);
> -}
> -EXPORT_SYMBOL_GPL(vsp1_du_setup_lif);
> -
> /**
> * vsp1_du_atomic_begin - Prepare for an atomic update
> * @dev: the VSP device
> diff --git a/include/media/vsp1.h b/include/media/vsp1.h
> index 13f5a1c4d45a..bc0a26d33d9a 100644
> --- a/include/media/vsp1.h
> +++ b/include/media/vsp1.h
> @@ -20,28 +20,6 @@ int vsp1_du_init(struct device *dev);
> #define VSP1_DU_STATUS_COMPLETE BIT(0)
> #define VSP1_DU_STATUS_WRITEBACK BIT(1)
>
> -/**
> - * struct vsp1_du_lif_config - VSP LIF configuration - Deprecated
> - * @width: output frame width
> - * @height: output frame height
> - * @interlaced: true for interlaced pipelines
> - * @callback: frame completion callback function (optional). When a callback
> - * is provided, the VSP driver guarantees that it will be called once
> - * and only once for each vsp1_du_atomic_flush() call.
> - * @callback_data: data to be passed to the frame completion callback
> - */
> -struct vsp1_du_lif_config {
> - unsigned int width;
> - unsigned int height;
> - bool interlaced;
> -
> - void (*callback)(void *data, unsigned int status, u32 crc);
> - void *callback_data;
> -};
> -
> -int vsp1_du_setup_lif(struct device *dev, unsigned int pipe_index,
> - const struct vsp1_du_lif_config *cfg);
> -
> /**
> * struct vsp1_du_modeset_config - VSP LIF Mode configuration
> * @width: output frame width

--
Regards,

Laurent Pinchart

\
 
 \ /
  Last update: 2019-06-12 16:45    [W:0.037 / U:18.404 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site