lkml.org 
[lkml]   [2019]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: build warning after merge of the i2c tree
Em Wed, 12 Jun 2019 13:09:04 +0200
Wolfram Sang <wsa@the-dreams.de> escreveu:

> Hi Mauro,
>
> > That entire use of _P, _R and _ri looks weird into my eyes. The code there
>
> Yes.
>
> > do things like:
> >
> > #define _P 32
> >
> > ...
> >
> > if (_P == 64)
> > reg1[1] |= 0x40;
>
> Yup, I saw this, too, but didn't feel like refactoring the driver.
> Thanks for stepping up!
>
> > I'll work on a patch to address it.
>
> OK, so that means I should send my pull request after yours in the next
> merge window? To avoid the build breakage?

Either that or you can apply my patch on your tree before the
patch that caused the breakage.

Just let me know what works best for you.

>
> Kind regards,
>
> Wolfram
>



Thanks,
Mauro

\
 
 \ /
  Last update: 2019-06-12 13:48    [W:0.053 / U:9.196 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site