lkml.org 
[lkml]   [2019]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: build warning after merge of the i2c tree
Hi Mauro,

> That entire use of _P, _R and _ri looks weird into my eyes. The code there

Yes.

> do things like:
>
> #define _P 32
>
> ...
>
> if (_P == 64)
> reg1[1] |= 0x40;

Yup, I saw this, too, but didn't feel like refactoring the driver.
Thanks for stepping up!

> I'll work on a patch to address it.

OK, so that means I should send my pull request after yours in the next
merge window? To avoid the build breakage?

Kind regards,

Wolfram

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-06-12 13:09    [W:0.049 / U:2.984 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site