Messages in this thread | | | Date | Wed, 12 Jun 2019 10:41:42 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v3 2/2] mfd: rk808: Prepare rk805 for poweroff |
| |
On Fri, 07 Jun 2019, Stefan Mavrodiev wrote:
> RK805 has SLEEP signal, which can put the device into SLEEP or OFF > mode. The default is SLEEP mode. > > However, when the kernel performs power-off (actually the ATF) the > device will not go fully off and this will result in higher power > consumption and inability to wake the device with RTC alarm. > > The solution is to enable pm_power_off_prepare function, which will > configure SLEEP pin for OFF function. > > Signed-off-by: Stefan Mavrodiev <stefan@olimex.com> > --- > Change for v3: > - Remove useless warning messages > - Change poweroff error messages > - Add explanation comments > Changes for v2: > - Move pm_pwroff_prep_fn to header > - Check pm_power_off_prepare before make it NULL > > drivers/mfd/rk808.c | 50 +++++++++++++++++++++++++++------------ > include/linux/mfd/rk808.h | 1 + > 2 files changed, 36 insertions(+), 15 deletions(-)
Applied, thanks.
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |