lkml.org 
[lkml]   [2019]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] arm64: Don't unconditionally add -Wno-psabi to KBUILD_CFLAGS
On Wed, Jun 12, 2019 at 10:25:20AM +0100, Dave Martin wrote:
> On Tue, Jun 11, 2019 at 10:19:32AM -0700, Nathan Chancellor wrote:
> > v1 -> v2:
> >
> > * Improve commit message explanation, I wasn't entirely happy with the
> > first one; let me know if there are any issues/questions.
> >
> > * Carry forward Dave's ack and Nick's review (let me know if you
> > disagree with the commit messasge rewording).
> >
> > arch/arm64/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> > index 8fbd583b18e1..e9d2e578cbe6 100644
> > --- a/arch/arm64/Makefile
> > +++ b/arch/arm64/Makefile
> > @@ -51,7 +51,7 @@ endif
> >
> > KBUILD_CFLAGS += -mgeneral-regs-only $(lseinstr) $(brokengasinst)
> > KBUILD_CFLAGS += -fno-asynchronous-unwind-tables
> > -KBUILD_CFLAGS += -Wno-psabi
> > +KBUILD_CFLAGS += $(call cc-disable-warning, psabi)
> > KBUILD_AFLAGS += $(lseinstr) $(brokengasinst)
> >
> > KBUILD_CFLAGS += $(call cc-option,-mabi=lp64)
>
> Looks OK to me. Thanks for the additional explanation.

I'd already queued the previous version, but somehow forgotten to push it
out. I'll push this one out instead later today.

Cheers,

Will

\
 
 \ /
  Last update: 2019-06-12 11:34    [W:0.028 / U:5.784 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site