| From | Linus Walleij <> | Date | Wed, 12 Jun 2019 10:54:10 +0200 | Subject | Re: [PATCH-next 13/20] gpio: gpio-omap: simplify omap_toggle_gpio_edge_triggering() |
| |
On Mon, Jun 10, 2019 at 7:12 PM Grygorii Strashko <grygorii.strashko@ti.com> wrote:
> From: Russell King <rmk+kernel@armlinux.org.uk> > > This function open-codes an exclusive-or bitwise operation using an > if() statement and explicitly setting or clearing the bit. Instead, > use an exclusive-or operation instead, and simplify the function. > > We can combine the preprocessor conditional using IS_ENABLED() and > gain some additional compilation coverage. > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Patch applied.
Yours, Linus Walleij
|