Messages in this thread | | | Date | Tue, 11 Jun 2019 16:34:35 -0700 | From | Bjorn Andersson <> | Subject | Re: [PATCH v3 2/5] interconnect: qcom: Add QCS404 interconnect provider driver |
| |
On Tue 11 Jun 09:41 PDT 2019, Georgi Djakov wrote:
This looks good, just two minor things.
> diff --git a/drivers/interconnect/qcom/qcs404.c b/drivers/interconnect/qcom/qcs404.c > new file mode 100644 > index 000000000000..99be0928e2ad > --- /dev/null > +++ b/drivers/interconnect/qcom/qcs404.c > @@ -0,0 +1,539 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2019 Linaro Ltd > + */ > + > +#include <dt-bindings/interconnect/qcom,qcs404.h> > +#include <linux/clk.h> > +#include <linux/device.h> > +#include <linux/interconnect-provider.h> > +#include <linux/io.h> > +#include <linux/module.h> > +#include <linux/of_device.h> > +#include <linux/of_platform.h> > +#include <linux/platform_device.h> > +#include <linux/slab.h> > + > +#include "smd-rpm.h"
This file and the two functions defined therein doesn't exist until patch 4, so please move this patch later in the series.
[..] > diff --git a/include/dt-bindings/interconnect/qcom,qcs404.h b/include/dt-bindings/interconnect/qcom,qcs404.h
I think the preferred way is to have the DT binding headers as part of the DT binding patch.
Regards, Bjorn
| |