Messages in this thread | | | Date | Tue, 11 Jun 2019 21:30:10 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH RESEND 1/7] sched/core: Fix preempt_schedule() interrupt return comment |
| |
On Tue, 28 May 2019, Valentin Schneider wrote: > Duh, forgot to cc the relevant folks on this one...
Nevertheless:
Acked-by: Thomas Gleixner <tglx@linutronix.de>
> On 28/05/2019 11:48, Valentin Schneider wrote: > > preempt_schedule_irq() is the one that should be called on return from > > interrupt, clean up the comment to avoid any ambiguity. > > > > Signed-off-by: Valentin Schneider <valentin.schneider@arm.com> > > --- > > kernel/sched/core.c | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > > index 874c427742a9..55ebc2cfb08c 100644 > > --- a/kernel/sched/core.c > > +++ b/kernel/sched/core.c > > @@ -3600,9 +3600,8 @@ static void __sched notrace preempt_schedule_common(void) > > > > #ifdef CONFIG_PREEMPT > > /* > > - * this is the entry point to schedule() from in-kernel preemption > > - * off of preempt_enable. Kernel preemptions off return from interrupt > > - * occur there and call schedule directly. > > + * This is the entry point to schedule() from in-kernel preemption > > + * off of preempt_enable. > > */ > > asmlinkage __visible void __sched notrace preempt_schedule(void) > > { > > @@ -3673,7 +3672,7 @@ EXPORT_SYMBOL_GPL(preempt_schedule_notrace); > > #endif /* CONFIG_PREEMPT */ > > > > /* > > - * this is the entry point to schedule() from kernel preemption > > + * This is the entry point to schedule() from kernel preemption > > * off of irq context. > > * Note, that this is called and return with irqs disabled. This will > > * protect us against recursive calling from irq. > > >
| |