lkml.org 
[lkml]   [2019]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH-next 07/20] gpio: gpio-omap: simplify omap_gpio_get_direction()
Date
From: Russell King <rmk+kernel@armlinux.org.uk>

Architectures are single-copy atomic, which means that simply reading
a register is an inherently atomic operation. There is no need to
take a spinlock here.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
drivers/gpio/gpio-omap.c | 13 +++----------
1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index cc320d09d074..44a4287cce9e 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -953,17 +953,10 @@ static void omap_gpio_free(struct gpio_chip *chip, unsigned offset)

static int omap_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
{
- struct gpio_bank *bank;
- unsigned long flags;
- void __iomem *reg;
- int dir;
+ struct gpio_bank *bank = gpiochip_get_data(chip);

- bank = gpiochip_get_data(chip);
- reg = bank->base + bank->regs->direction;
- raw_spin_lock_irqsave(&bank->lock, flags);
- dir = !!(readl_relaxed(reg) & BIT(offset));
- raw_spin_unlock_irqrestore(&bank->lock, flags);
- return dir;
+ return !!(readl_relaxed(bank->base + bank->regs->direction) &
+ BIT(offset));
}

static int omap_gpio_input(struct gpio_chip *chip, unsigned offset)
--
2.17.1
\
 
 \ /
  Last update: 2019-06-10 19:12    [W:0.168 / U:9.660 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site