Messages in this thread | | | From | Stephen Boyd <> | Subject | Re: [PATCH 5/6] arm64: dts: Add ipq6018 SoC and CP01 board support | Date | Mon, 10 Jun 2019 09:48:04 -0700 |
| |
Quoting Sricharan R (2019-06-10 08:45:22) > On 6/8/2019 9:18 AM, Bjorn Andersson wrote: > > On Wed 05 Jun 10:16 PDT 2019, Sricharan R wrote: > >> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > >> new file mode 100644 > >> index 0000000..79cccdd > >> --- /dev/null > >> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi > >> + compatible = "fixed-clock"; > >> + clock-frequency = <32000>; > >> + #clock-cells = <0>; > >> + }; > >> + > >> + xo: xo { > >> + compatible = "fixed-clock"; > >> + clock-frequency = <24000000>; > >> + #clock-cells = <0>; > >> + }; > >> + > >> + bias_pll_cc_clk { > > > > Please give this a label and reference it from the node that uses it > > (regardless of the implementation matching by clock name). > > > ok, in that case, so might have to remove these for now, till we add > the corresponding users.
Yes, please remove them. They don't look like board clks, instead they're SoC level details that need to be created by some clk driver like GCC.
> > >> + compatible = "fixed-clock"; > >> + clock-frequency = <300000000>; > >> + #clock-cells = <0>; > >> + }; > >> + > >> + bias_pll_nss_noc_clk { > >> + compatible = "fixed-clock"; > >> + clock-frequency = <416500000>; > >> + #clock-cells = <0>; > >> + }; > >> +
| |