Messages in this thread | | | From | Sergey Matyukevich <> | Subject | Re: [PATCH][next] qtnfmac: Use struct_size() in kzalloc() | Date | Mon, 10 Jun 2019 16:14:00 +0000 |
| |
> One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct ieee80211_regdomain { > ... > struct ieee80211_reg_rule reg_rules[]; > }; > > instance = kzalloc(sizeof(*mac->rd) + > sizeof(struct ieee80211_reg_rule) * > count, GFP_KERNEL); > > Instead of leaving these open-coded and prone to type mistakes, we can > now use the new struct_size() helper: > > instance = kzalloc(struct_size(instance, reg_rules, count), GFP_KERNEL); > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Hi Gustavo, Thanks for the patch !
Reviewed-by: Sergey Matyukevich <sergey.matyukevich.os@quantenna.com>
Regards, Sergey
| |