lkml.org 
[lkml]   [2019]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] pinctrl: qcom: Clear status bit on irq_unmask
    Date
    Quoting Linus Walleij (2019-06-07 14:08:10)
    > On Fri, May 31, 2019 at 8:52 AM Tengfei Fan <tengfeif@codeaurora.org> wrote:
    >
    > > The gpio interrupt status bit is getting set after the
    > > irq is disabled and causing an immediate interrupt after
    > > enablling the irq, so clear status bit on irq_unmask.
    > >
    > > Signed-off-by: Tengfei Fan <tengfeif@codeaurora.org>
    >
    > This looks pretty serious, can one of the Qcom maintainers ACK
    > this?
    >
    > Should it be sent to fixes and even stable?
    >
    > Fixes: tag?
    >

    How is the interrupt status bit getting set after the irq is disabled?
    It looks like this is a level type interrupt? I thought that after
    commit b55326dc969e ("pinctrl: msm: Really mask level interrupts to
    prevent latching") this wouldn't be a problem. Am I wrong, or is qcom
    just clearing out patches on drivers and this is the last one that needs
    to be upstreamed?

    \
     
     \ /
      Last update: 2019-06-10 16:52    [W:2.226 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site