lkml.org 
[lkml]   [2019]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] s390: drop meaningless 'targets' from tools Makefile
On Fri, May 17, 2019 at 04:54:27PM +0900, Masahiro Yamada wrote:
> 'targets' should be specified to include .*.cmd files to evaluate
> if_changed or friends.
>
> Here, facility-defs.h and dis-defs.h are generated by filechk.
>
> Because filechk does not generate .*.cmd file, the 'targets' addition
> is meaningless. The filechk correctly updates the target when its
> content is changed.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/s390/tools/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/s390/tools/Makefile b/arch/s390/tools/Makefile
> index 4864ea5e6ceb..b5e35e8f999a 100644
> --- a/arch/s390/tools/Makefile
> +++ b/arch/s390/tools/Makefile
> @@ -6,7 +6,6 @@
> kapi := arch/$(ARCH)/include/generated/asm
> kapi-hdrs-y := $(kapi)/facility-defs.h $(kapi)/dis-defs.h
>
> -targets += $(addprefix ../../../,$(kapi-hdrs-y))

Applied, thanks.

\
 
 \ /
  Last update: 2019-06-01 12:24    [W:0.052 / U:0.612 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site