lkml.org 
[lkml]   [2019]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 018/141] drivers: thermal: tsens: Don't print error message on -EPROBE_DEFER
    Date
    From: Amit Kucheria <amit.kucheria@linaro.org>

    [ Upstream commit fc7d18cf6a923cde7f5e7ba2c1105bb106d3e29a ]

    We print a calibration failure message on -EPROBE_DEFER from
    nvmem/qfprom as follows:
    [ 3.003090] qcom-tsens 4a9000.thermal-sensor: version: 1.4
    [ 3.005376] qcom-tsens 4a9000.thermal-sensor: tsens calibration failed
    [ 3.113248] qcom-tsens 4a9000.thermal-sensor: version: 1.4

    This confuses people when, in fact, calibration succeeds later when
    nvmem/qfprom device is available. Don't print this message on a
    -EPROBE_DEFER.

    Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
    Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/thermal/qcom/tsens.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
    index a2c9bfae3d867..b139713289a42 100644
    --- a/drivers/thermal/qcom/tsens.c
    +++ b/drivers/thermal/qcom/tsens.c
    @@ -171,7 +171,8 @@ static int tsens_probe(struct platform_device *pdev)
    if (tmdev->ops->calibrate) {
    ret = tmdev->ops->calibrate(tmdev);
    if (ret < 0) {
    - dev_err(dev, "tsens calibration failed\n");
    + if (ret != -EPROBE_DEFER)
    + dev_err(dev, "tsens calibration failed\n");
    return ret;
    }
    }
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-06-01 15:23    [W:4.111 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site