| Date | Sat, 1 Jun 2019 09:27:56 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 4.19 130/276] block: fix use-after-free on gendisk |
| |
Hi!
> +++ b/block/genhd.c > @@ -518,6 +518,18 @@ void blk_free_devt(dev_t devt) > } > } > > +/** > + * We invalidate devt by assigning NULL pointer for devt in idr. > + */ > +void blk_invalidate_devt(dev_t devt) > +{ > + if (MAJOR(devt) == BLOCK_EXT_MAJOR) { > + spin_lock_bh(&ext_devt_lock); > + idr_replace(&ext_devt_idr, NULL, blk_mangle_minor(MINOR(devt))); > + spin_unlock_bh(&ext_devt_lock); > + } > +} > +
AFAICT /** means linuxdoc, but the comment does not have required format. Probably should be just /*.
Thanks, Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] |