lkml.org 
[lkml]   [2019]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 22/66] ASoC: dapm: Fix NULL pointer dereference in snd_soc_dapm_free_kcontrol
    Date
    [ Upstream commit cacea3a90e211f0c111975535508d446a4a928d2 ]

    w_text_param can be NULL and it is being dereferenced without checking.
    Add the missing sanity check to prevent NULL pointer dereference.

    Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
    Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/soc-dapm.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
    index 9b78fb3daa7bb..2257b1b0151c4 100644
    --- a/sound/soc/soc-dapm.c
    +++ b/sound/soc/soc-dapm.c
    @@ -3847,6 +3847,10 @@ snd_soc_dapm_free_kcontrol(struct snd_soc_card *card,
    int count;

    devm_kfree(card->dev, (void *)*private_value);
    +
    + if (!w_param_text)
    + return;
    +
    for (count = 0 ; count < num_params; count++)
    devm_kfree(card->dev, (void *)w_param_text[count]);
    devm_kfree(card->dev, w_param_text);
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-05-09 21:06    [W:2.427 / U:1.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site