lkml.org 
[lkml]   [2019]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 28/66] drm/mediatek: Fix an error code in mtk_hdmi_dt_parse_pdata()
    Date
    [ Upstream commit 2d85978341e6a32e7443d9f28639da254d53f400 ]

    We don't want to overwrite "ret", it already holds the correct error
    code. The "regmap" variable might be a valid pointer as this point.

    Fixes: 8f83f26891e1 ("drm/mediatek: Add HDMI support")
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: CK Hu <ck.hu@mediatek.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/mediatek/mtk_hdmi.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c
    index 643f5edd68fe3..c7a77d6f612b2 100644
    --- a/drivers/gpu/drm/mediatek/mtk_hdmi.c
    +++ b/drivers/gpu/drm/mediatek/mtk_hdmi.c
    @@ -1473,7 +1473,6 @@ static int mtk_hdmi_dt_parse_pdata(struct mtk_hdmi *hdmi,
    if (IS_ERR(regmap))
    ret = PTR_ERR(regmap);
    if (ret) {
    - ret = PTR_ERR(regmap);
    dev_err(dev,
    "Failed to get system configuration registers: %d\n",
    ret);
    --
    2.20.1


    \
     
     \ /
      Last update: 2019-05-09 21:06    [W:4.122 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site