lkml.org 
[lkml]   [2019]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 04/95] staging: greybus: power_supply: fix prop-descriptor request size
    Date
    From: Johan Hovold <johan@kernel.org>

    commit 47830c1127ef166af787caf2f871f23089610a7f upstream.

    Since moving the message buffers off the stack, the dynamically
    allocated get-prop-descriptor request buffer is incorrectly sized due to
    using the pointer rather than request-struct size when creating the
    operation.

    Fortunately, the pointer size is always larger than this one-byte
    request, but this could still cause trouble on the remote end due to the
    unexpected message size.

    Fixes: 9d15134d067e ("greybus: power_supply: rework get descriptors")
    Cc: stable <stable@vger.kernel.org> # 4.9
    Cc: Rui Miguel Silva <rui.silva@linaro.org>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/staging/greybus/power_supply.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/staging/greybus/power_supply.c
    +++ b/drivers/staging/greybus/power_supply.c
    @@ -520,7 +520,7 @@ static int gb_power_supply_prop_descript

    op = gb_operation_create(connection,
    GB_POWER_SUPPLY_TYPE_GET_PROP_DESCRIPTORS,
    - sizeof(req), sizeof(*resp) + props_count *
    + sizeof(*req), sizeof(*resp) + props_count *
    sizeof(struct gb_power_supply_props_desc),
    GFP_KERNEL);
    if (!op)

    \
     
     \ /
      Last update: 2019-05-09 20:51    [W:4.111 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site