Messages in this thread | | | Date | Thu, 9 May 2019 14:36:29 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 2/4] x86/kprobes: Fix frame pointer annotations |
| |
On Thu, 9 May 2019 20:26:22 +0200 Peter Zijlstra <peterz@infradead.org> wrote:
> Still, maybe we can wrap the thing in a .macro and reuse things that > way. Because I really hate there are at least 3 (x2 for x86_64) copies > of this around.
I'm good with something like this. Have a single place that does the pt_regs saving would be great. Then I could separate ftrace_regs_caller from ftrace_caller, and simplify them both, as I would only need to make sure frame pointers still work for ftrace_caller, and ftrace_regs_caller would depend on the macro to make sure it works.
-- Steve
| |