lkml.org 
[lkml]   [2019]   [May]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 03/10] PCI/DPC: Log messages with pci_dev, not pcie_device
On Thu, May 9, 2019 at 5:18 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> Log messages with pci_dev, not pcie_device. Factor out common message
> prefixes with dev_fmt().
>
> Example output change:
>
> - dpc 0000:00:01.1:pcie008: DPC error containment capabilities...
> + pcieport 0000:00:01.1: DPC: error containment capabilities...

Overall same question about Capitalizing sentences.

> + pci_err(pdev, "rp_pio_status: %#010x, rp_pio_mask: %#010x\n",

And here perhaps RP PIO status: ... mask: ... ?
See below I left examples from this patch.

> status, mask);

> + pci_err(pdev, "RP PIO severity=%#010x, syserror=%#010x, exception=%#010x\n",
> sev, syserr, exc);

> + pci_err(pdev, "RP PIO ImpSpec Log %#010x\n", log);

> + pci_err(pdev, "RP PIO log size %u is invalid\n",
> dpc->rp_log_size);

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2019-05-09 19:40    [W:0.193 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site