Messages in this thread | | | From | Daniel Drake <> | Date | Thu, 9 May 2019 14:08:38 +0800 | Subject | Re: [PATCH v3 04/11] platform/x86: asus-wmi: Improve DSTS WMI method ID detection |
| |
> > -#define ASUS_WMI_METHODID_DSTS 0x53544344 /* Device STatuS */ > > -#define ASUS_WMI_METHODID_DSTS2 0x53545344 /* Device STatuS #2*/ > > > +#define ASUS_WMI_METHODID_DSTS 0x53544344 /* Device STatuS (DCTS) */ > > It's not clear from the description what 'C' stands for. > Is there any specification which describes the difference and actual > abbreviations?
The (recent) spec I have here doesn't mention 0x53544344 (DCTS). However the spec changelog does mention that EEEPC stuff was removed from the spec a while ago. The spec does mention 0x53545344 (DSTS), labelled as "Get device status".
For clarity I think the constants could be renamed as ASUS_WMI_METHODID_DCTS and ASUS_WMI_METHODID_DSTS.
Daniel
| |