Messages in this thread | | | Date | Thu, 9 May 2019 10:23:47 +0100 | From | Patrick Bellasi <> | Subject | Re: [PATCH v8 06/16] sched/core: uclamp: Extend sched_setattr() to support utilization clamping |
| |
On 08-May 21:41, Peter Zijlstra wrote: > On Tue, Apr 02, 2019 at 11:41:42AM +0100, Patrick Bellasi wrote: > > @@ -1056,6 +1100,13 @@ static void __init init_uclamp(void) > > #else /* CONFIG_UCLAMP_TASK */ > > static inline void uclamp_rq_inc(struct rq *rq, struct task_struct *p) { } > > static inline void uclamp_rq_dec(struct rq *rq, struct task_struct *p) { } > > +static inline int uclamp_validate(struct task_struct *p, > > + const struct sched_attr *attr) > > +{ > > + return -ENODEV; > > Does that maybe want to be -EOPNOTSUPP ?
Suren propose ENOSYS for another similar case, i.e. !CONFIG_UCLAMP_TASK definitions.
But EOPNOTSUPP seems more appropriate to me too.
-- #include <best/regards.h>
Patrick Bellasi
| |