Messages in this thread | | | From | Vitaly Kuznetsov <> | Subject | Re: [PATCH 2/6] x86: hv: hv_init.c: Replace alloc_page() with kmem_cache_alloc() | Date | Wed, 08 May 2019 15:53:03 -0400 |
| |
Stephen Hemminger <sthemmin@microsoft.com> writes:
> I would worry that kmem_cache_alloc does not currently have same alignment constraints. > See discussion here: > https://lwn.net/SubscriberLink/787740/a886fe4ea6681322/
I think it even was me who reported this bug with XFS originally :-)
Yes, plain kmalloc() doesn't give you alignment guarantees (it is very easy to prove, e.g. with CONFIG_KASAN), however, kmem_cache_create() (and dma_pool_create() to that matter) has explicit 'align' parameter and it is a bug if it is not respected.
-- Vitaly
| |