Messages in this thread | | | From | Akinobu Mita <> | Date | Thu, 9 May 2019 00:40:14 +0900 | Subject | Re: [PATCH v2 3/7] devcoredump: allow to create several coredump files in one device |
| |
2019年5月8日(水) 2:35 Heitke, Kenneth <kenneth.heitke@intel.com>: > > > > On 5/7/2019 10:58 AM, Akinobu Mita wrote: > > @@ -292,6 +309,12 @@ void dev_coredumpm(struct device *dev, struct module *owner, > > if (device_add(&devcd->devcd_dev)) > > goto put_device; > > > > + for (i = 0; i < devcd->num_files; i++) { > > + if (device_create_bin_file(&devcd->devcd_dev, > > + &devcd->files[i].bin_attr)) > > + /* nothing - some files will be missing */; > > Is the conditional necessary if you aren't going to do anything?
The device_create_bin_file() is declared with __must_check, so ignoring the return value emits warning.
| |