lkml.org 
[lkml]   [2019]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] watchdog: sama5d4: fix WDD value to be always set to max
    Date
    From: Eugen Hristev <eugen.hristev@microchip.com>

    WDD value must be always set to max (0xFFF) otherwise the hardware
    block will reset the board on the first ping of the watchdog.

    Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
    ---
    drivers/watchdog/sama5d4_wdt.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c
    index 1e93c1b..d495336 100644
    --- a/drivers/watchdog/sama5d4_wdt.c
    +++ b/drivers/watchdog/sama5d4_wdt.c
    @@ -111,9 +111,7 @@ static int sama5d4_wdt_set_timeout(struct watchdog_device *wdd,
    u32 value = WDT_SEC2TICKS(timeout);

    wdt->mr &= ~AT91_WDT_WDV;
    - wdt->mr &= ~AT91_WDT_WDD;
    wdt->mr |= AT91_WDT_SET_WDV(value);
    - wdt->mr |= AT91_WDT_SET_WDD(value);

    /*
    * WDDIS has to be 0 when updating WDD/WDV. The datasheet states: When
    @@ -251,7 +249,7 @@ static int sama5d4_wdt_probe(struct platform_device *pdev)

    timeout = WDT_SEC2TICKS(wdd->timeout);

    - wdt->mr |= AT91_WDT_SET_WDD(timeout);
    + wdt->mr |= AT91_WDT_SET_WDD(WDT_SEC2TICKS(MAX_WDT_TIMEOUT));
    wdt->mr |= AT91_WDT_SET_WDV(timeout);

    ret = sama5d4_wdt_init(wdt);
    --
    2.7.4
    \
     
     \ /
      Last update: 2019-05-08 16:16    [W:3.735 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site