Messages in this thread Patch in this message | | | From | Alexandru Ardelean <> | Subject | [PATCH 04/16] powerpc/xmon: use new match_string() helper/macro | Date | Wed, 8 May 2019 14:28:30 +0300 |
| |
The change is purely cosmetic at this point in time, but it does highlight the change done in lib/string.c for match_string().
Particularly for this change, if a regname is removed (replaced with NULL) in the list, the match_string() helper will continue until the end of the array and ignore the NULL. This would technically allow for "reserved" regs, though here it's not the case.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com> --- arch/powerpc/xmon/xmon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c index efca104ac0cb..b84a7fc1112b 100644 --- a/arch/powerpc/xmon/xmon.c +++ b/arch/powerpc/xmon/xmon.c @@ -3231,7 +3231,7 @@ scanhex(unsigned long *vp) regname[i] = c; } regname[i] = 0; - i = __match_string(regnames, N_PTREGS, regname); + i = match_string(regnames, regname); if (i < 0) { printf("invalid register name '%%%s'\n", regname); return 0; -- 2.17.1
| |