lkml.org 
[lkml]   [2019]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V5 09/16] Documentation/devicetree: Add PCIe supports-clkreq property
From
Date
On 4/26/2019 8:52 PM, Rob Herring wrote:
> On Wed, Apr 24, 2019 at 10:49:57AM +0530, Vidya Sagar wrote:
>> Some host controllers need to know the existence of clkreq signal routing to
>> downstream devices to be able to advertise low power features like ASPM L1
>> substates. Without clkreq signal routing being present, enabling ASPM L1 sub
>> states might lead to downstream devices falling off the bus. Hence a new device
>> tree property 'supports-clkreq' is added to make such host controllers
>> aware of clkreq signal routing to downstream devices.
>
> Please be consistent with subjects (Use 'dt-bindings: ...')
When I had made this change, I did a git log and saw 'Documentation/devicetree:' as
the prefix and hence added it. But, now, with linux-next top of the tree, I see
two more commits with 'dt-bindings:' prefix. I'll change my patch also to the new
'dt-bindings:' prefix.

>
> With that change,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
>>
>> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
>> ---
>> Changes since [v4]:
>> * None
>>
>> Changes since [v3]:
>> * Rebased on top of linux-next top of the tree
>>
>> Changes since [v2]:
>> * None
>>
>> Changes since [v1]:
>> * This is a new patch in v2 series
>>
>> Documentation/devicetree/bindings/pci/pci.txt | 5 +++++
>> 1 file changed, 5 insertions(+)

\
 
 \ /
  Last update: 2019-05-07 10:32    [W:0.135 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site