Messages in this thread | | | From | Dan Williams <> | Date | Tue, 7 May 2019 17:30:15 -0700 | Subject | Re: [PATCH v2 8/8] mm/memory_hotplug: Remove "zone" parameter from sparse_remove_one_section |
| |
On Tue, May 7, 2019 at 11:39 AM David Hildenbrand <david@redhat.com> wrote: > > Unused, and memory unplug path should never care about zones. This is > the job of memory offlining. ZONE_DEVICE might require special care - > the caller of arch_remove_memory() should handle this.
The ZONE_DEVICE usage does not require special care so you can drop that comment. The only place it's used in the subsection patches is to lookup the node-id, but it turns out that the resulting node-id is then never used.
With the ZONE_DEVICE mention dropped out of changelog you can add:
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
| |